Re: Crash during Traditional Chinese <-> Simplified Chinese conversion

Hi Cedric,

On Tue, 05 Feb 2013 15:01:36 +0100
Cedric Bosdonnat <cbosdonnat@suse.com> wrote:

> On Mon, 2013-02-04 at 12:27 +0100, Michael Stahl wrote:
> > On 03/02/13 10:54, Cedric Bosdonnat wrote:
> > > Hi Matteo,
> > >
> > > On Fri, 2013-01-04 at 14:58 +0100, Matteo Casalin wrote:
> > > > Obviously, this would not work since we will get the same issue on the 
> > > > second loop. Instead we can push PaM information (on which to 
> > > > SetFontAndLanguage) in a queue and then iterate on it after the main 
> > > > loop is completed. I'll start working on a patch and see what happens 
> > > > with the Chinese document I have available. If that works, I'll submit 
> > > > the patch to gerrit, hoping that someone could also apply broader tests 
> > > > on the results (I don't have any knowledge of Chinese).
> > >
> > > I can help you test if you need, my limited knowledge of chinese may be
> > > OK to check the conversions ;)
> >
> > the change was committed a month ago so there is nothing stopping you
> > from testing this:  a0477d991661de605aec4fec87ca52e32ec8f743
>
> I tested on a big list of chinese characters to convert and found no
> problem. And the patch looks safe, so nothing worse than before IMHO.

Thank you very much!
I'll try to fix the remaining issue(s) ASAP, I really would like this thing to work.
From my debugging I understood that the text is changed by selecting the desired range of 
characters and then replacing that selection. In this case, the selection is misplaced, but I still 
haven't been able to understand why.

Thanks againg
Ciao

> --
> Cedric
>
> _______________________________________________
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice