Date: prev next · Thread: first prev next last
2013 Archives by date, by thread · List index


Christina Roßmanith wrote:
I had a look at cui/source/tabpages/tpline.cxx and found two
identical blocks in
sal_Bool SvxLineTabPage::FillItemSet( SfxItemSet& rAttrs ) around
lines 767 and 871. Could someone confirm (and maybe explain) that
this is intentional.

Some mismerge - feel free to kill one instance.

And code like if( nDlgType != 0 || nPageType != 3 ) is difficult to
read. There are constants defined in source/tabpages/numpages.cxx,
e.g. #define NUM_PAGETYPE_BULLET 0 but I don't know if those match
the ones used in tpline.cxx.

Well NUM_PAGETYPE_BULLET does not sound like a plausible match for the
tpline.cxx. There's also svx/inc/svx/tabarea.hxx's PageType enum - so
in the end I have no idea, this needs some carefully placed
breakpoints to determine if/when that code is called. Status quo is
clearing a bit lacking...

Cheers,

-- Thorsten

Attachment: signature.asc
Description: Digital signature


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.