Date: prev next · Thread: first prev next last
2013 Archives by date, by thread · List index


Hi,

On Wed, Jan 02, 2013 at 05:32:45PM +0100, Lubos Lunak wrote:
On Tuesday 01 of January 2013, Libreoffice Gerrit user wrote:
commit 085e0adf53baff298059980a54758d81b08bb059
Author: David Tardon <dtardon@redhat.com>
Date:   Tue Jan 1 11:47:56 2013 +0100

    just pass the define through -D

    I am constantly amazed at the creativity of the original makefile
    writers. An extra header file, processed by sed, rather then adding one
    item to CDEFS? Really?

 Please use config_xxx.h files rather than -D flags whenever possible (which, 
interestingly, is an extra header file, processed by sed, rather than adding 
one item to CDEFS).

But it is a "standard" way of adding defined symbols (i.e., the header
is created automagically by configure). Writing a custom makefile code
that runs sed and produces a header file is not standard (and never has
been).

D.

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.