zipcore

Lubos Lunak <l.lunak -AT- suse.cz>
Wed, 2 Jan 2013 17:32:45 +0100

On Tuesday 01 of January 2013, Libreoffice Gerrit user wrote:

commit 085e0adf53baff298059980a54758d81b08bb059
Author: David Tardon <dtardon@redhat.com>
Date:   Tue Jan 1 11:47:56 2013 +0100

    just pass the define through -D

    I am constantly amazed at the creativity of the original makefile
    writers. An extra header file, processed by sed, rather then adding one
    item to CDEFS? Really?


 Please use config_xxx.h files rather than -D flags whenever possible (which, 
interestingly, is an extra header file, processed by sed, rather than adding 
one item to CDEFS).

-- 
 Lubos Lunak
 l.lunak@suse.cz

Context

Re: [Libreoffice-commits] .: 2 commits - pyuno/CustomTarget_python_shell.mk pyuno/CustomTarget_pyversion.mk pyuno/Executable_python_wrapper.mk pyuno/Module_pyuno.mk pyuno/zipcore · Lubos Lunak
- Re: [Libreoffice-commits] .: 2 commits - pyuno/CustomTarget_python_shell.mk pyuno/CustomTarget_pyversion.mk pyuno/Executable_python_wrapper.mk pyuno/Module_pyuno.mk pyuno/zipcore · David Tardon

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.