Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index


Hi there,

        Thanks for the updated patch :-)

On Mon, 2012-12-10 at 08:08 -0800, Christos Strubulis wrote:
I haven't deleted helpcontent2 yet but I will do it before the
next autogen and compilation. 

        I removed it from the patch and pushed.

Would you like to have a look at the attached patch? What is
your opinion now?

        Lubos asked you to:

- SAL_CALL is already defined in sal/inc/sal/types.h , so there's no need to 
define it again in tools/inc/tools/solar.h , the definition of 
__LOADONCALLAPI should be simply removed there

 Can you submit a new patch with these changes ?

        I did that for you, since your patch still had the definition of
SAL_CALL included - did you send the wrong patch somehow ?

        Anyhow - thanks for your first contribution; good to get it in.

        All the best,

                Michael.

-- 
michael.meeks@suse.com  <><, Pseudo Engineer, itinerant idiot


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.