Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index


Hey Alexander,


sorry for breaking the build :/

Happens to everybody from time to time. Just for the next time it
might be good to do a full compile for such changes.


Stephan Bergmann wasn't sure whether it'd be better to revert the
commit or update the tests.

Well actually the right solution is to do neither of the two. The
patch catches that through your change old documents are looking
different now. So we actually should find a way to make the old
documents import as before. I think Thorsten already mentioned this in
another mail.


Since I didn't find a straight-forward way to adapt the test to the new
colors (Would I have to adapt a test-document?) I guess it's better to
revert it for now. Or should I wait for a response from Stephan?


As explained I think the right solution is to adapt the import code
but for the test the reference file are in sd/qa/unit/data/*

So if you really want to change the reference files because you are
aware of the change you just need to create them newly and commit
them.

Regards,
Markus

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.