Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index


On 11/29/2012 01:54 AM, Thorsten Behrens wrote:
ploughing through offapi & cppumaker (the tool that generates the
c++ headers), and so far did this:

  * unpublished accessibility API
  * renamed XAccessibleEventListener methods
  * cleansed cppumaker of dead code, RTL_CONSTASCII verbosity, and
    writing out exception specs

as discussed offline, did you keep the exception specifications as SAL_THROW comments?

There remain the following open questions:

  * should we keep ~MyClass() {} throw() - or rather have just one
    single proper virtual ~XInterface() {} throw in the base class
    (note the missing virtual all over the place) - or bin all
    exception specs unconditionally?

I would refrain from such a massive change as making ~XInterface virtual. And having nothrow specifications on destructors is fine IMO.

  * should we kill [oneway] in IDL while at it? IIRC it went away in
    the bridges anyway, via i#116038 or didn't it?

Yes, [oneway] is effectively completely dead by now (compared to almost dead before the binary URP rewrite).

  * a bit more extreme - kill ::com::sun::star inside office code, by
    having a ~global "using namespace ::com::sun::star;" or
    "namespace api = ::com::sun::star;" in e.g. sal/config.h, and
    writing only _that_ out in the generated c++ headers?
    (of course keep the old namespace for SDK. And yes, it's no new
    idea, just a bit less extreme as what's proposed in the wiki)

namespace css = com::sun:.star is the de-facto standard there, so yes, I wouldn't mind using that in the generated headers.

Stephan

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.