Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index


On 11/24/2012 09:39 PM, Jean-Baptiste Faure wrote:
The commit
http://cgit.freedesktop.org/libreoffice/core/commit/?id=b7e6c8459b15a4fdb9ebb269b27cdeea82c8c5c2
allows to have an unabbreviated commit ID as build-ID in the About dialog
Unfortunatly the version number is then too long to fit the dialog box
on a single line.

On my build, the attached patch allows to have the version text on two
lines in the About dialog.
I do not know if I did the right thing. I reproduced what is done for
the description text but, perhaps, there was a good reason to do
differently for version text and description text.

I couldn't reproduce your problem until I noticed that the width of the About dialog actually depends on one's screen size, and I apparently have bigger screen than you. ;) Temporarily changing the divisor in the calculation of aIdealTextWidth from 2.4 to 4 made your problem appear for me, too.

Your patch looks reasonable to me, so I pushed it.

Thanks,
Stephan


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.