Re: [PUSHED 3-6-3] fix for fdo#54552, only use non blank cells in the visible data methods in ScColumn

Petr Mladek <pmladek -AT- suse.cz>
Mon, 22 Oct 2012 16:19:52 +0200

On Fri, 2012-10-19 at 16:12 +0200, Petr Mladek wrote:

On Fri, 2012-10-19 at 10:46 +0200, David Tardon wrote:

Hi,

On Wed, Oct 17, 2012 at 04:28:27PM +0200, Markus Mohrhard wrote:

Hey,

[1] fixes the problem that blank cells, like broadcaster, cells are
considerend non empty for the "visible" methods.


Pushed with my sign-off.


The commit in 3-6 branch is
http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-6&id=23e6bac62ef6482c287bb0f55c662ac2047ebb33

It looks reasonable and works fine => +1

One more approval is needed for 3-6-3. I would prefer if it is from a
Calc expert :-)


Approved and pushed by Eike.

Correct me if I am mistaken, but shouldn't the same check be used in
GetFirstVisDataPos and VisibleCount too?


Marcus is working on it.


Best Regards,
Petr

Context

[REVIEW 3-6 3-6-3] fix for fdo#54552, only use non blank cells in the visible data methods in ScColumn · Markus Mohrhard
- Re: [REVIEW 3-6-3][REVIEWED 3-6] fix for fdo#54552, only use non blank cells in the visible data methods in ScColumn · David Tardon
  - Re: [REVIEW 3-6-3 2/3] fix for fdo#54552, only use non blank cells in the visible data methods in ScColumn · Petr Mladek
    - Re: [PUSHED 3-6-3] fix for fdo#54552, only use non blank cells in the visible data methods in ScColumn · Eike Rathke
    - Re: [PUSHED 3-6-3] fix for fdo#54552, only use non blank cells in the visible data methods in ScColumn · Petr Mladek

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.