Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index


Hi,

On Friday, 2012-10-19 16:12:24 +0200, Petr Mladek wrote:
On Fri, 2012-10-19 at 10:46 +0200, David Tardon wrote:
On Wed, Oct 17, 2012 at 04:28:27PM +0200, Markus Mohrhard wrote:
[1] fixes the problem that blank cells, like broadcaster, cells are
considerend non empty for the "visible" methods.
Pushed with my sign-off.
The commit in 3-6 branch is
http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-6&id=23e6bac62ef6482c287bb0f55c662ac2047ebb33
It looks reasonable and works fine => +1
One more approval is needed for 3-6-3. I would prefer if it is from a
Calc expert :-)

Pushed with sign-offs
http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-6-3&id=c38b67a171615ddc444e0fe849e10d7cada74b6a

Correct me if I am mistaken, but shouldn't the same check be used in
GetFirstVisDataPos and VisibleCount too?

It would make sense.

I think so too, and before the change of note cell handling that was the
case. However, Markus said he'd like to have testcases for that first
before changing.

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD
Support the FSFE, care about Free Software! https://fsfe.org/support/?erack

Attachment: pgpqfUVW2bGx8.pgp
Description: PGP signature


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.