Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index


On Fri, 2012-10-19 at 13:10 +0200, Kohei Yoshida wrote:
On Wed, Oct 17, 2012 at 11:16 AM, Markus Mohrhard
<markus.mohrhard@googlemail.com> wrote:
Hey,

I just reviewed Noel's old patch for the sort problems around the sort
dialog. His patch fixes several problems at once where the sort
options are not exchanged between the tab pages.

I already pushed it to 3-6 but I'd like to see this pushed to 3-6-3 to
fix all of these problems in the next release.

Regards,
Markus

[1] 
http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-6&id=1bc15304a3fb44399ebd3861f6ee5fc12197a969

The change looks good to me.  I'll give my sign-off.  We need one more
sign-off to cherry-pick this to the 3-6-3 branch.

It seems that it should not cause any harm. It works well => approved
and pushed into 3-6-3.

Best Regards,
Petr


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.