Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index


Hi!

I unterstood... Thanks for comment! I'll do more and better next time
:-)


2012/10/1 Thorsten Behrens <thb@documentfoundation.org>

guilherme.sft@gmail.com wrote:
This patch removes '@author' annotation, code in comments
and adjust some empty catches. It's cleanup patch

Hi José Guilherme,

partially pushed - I left the hunks commenting empty methods as
FIXME instead of removing them straight away unapplied. If the
method is pointless, why not remove them in one go?

I also did not apply your printStackTrace() logging calls, I think
at least some of them report on exceptions that were seemingly
previously ignored on purpose?

Stephan, or anyone else more up-to-date with contemporary java
idiom, any opinions here?

Thanks for the nice cleanup anyways! :)

Cheers,

-- Thorsten




-- 
Att. José Guilherme Vanz
"Se você é capaz de tremer de indignação cada vez que se comete uma
injustiça no mundo, então somos companheiros" - Che Guevara

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.