Re: [PUSHED 3-6] For msi installer, only default-select a subset of dictionaries

2012/9/21 Stephan Bergmann <sbergman@redhat.com>:
> This is about backporting to libreoffice-3-6 the fix for part 1 of
> <https://bugs.freedesktop.org/show_bug.cgi?id=53009> "Large
> UserInstallation's user/extensions/bundled/ tree," namely default-selecting
> only a reasonable subset of the 40+ dictionaries that come included with
> LO's msi installer (see
> <https://bugs.freedesktop.org/show_bug.cgi?id=53009#c10>).
>
> I'm switching back to the good old way of using the ML rather than gerrit to
> propose this backport, for various reasons:
>
> * The fix spans multiple commits, for multiple issues and multiple
> repositories.  0001-Fix-for-fdo-53520-Portuguese-spelling-files.patch is for
> the dictionaries repo, the other 0001...0006 are for the core repo.
>
> * There was a naming inconsistency for the pt-BR and pt-PT dictionaries that
> caused the data in setup_native/source/packinfo/spellchecker_selection.txt
> (which is used in the fix) to not match reality, and
> <https://bugs.freedesktop.org/show_bug.cgi?id=53520> "[PACKAGING] Brazilian
> spell-check pt-BR named as pt-PT" fixes that, so the easiest (though
> somewhat further-reaching) solution is to backport that fix as well.  (Hence
> the many commits split across two repos.)
>
> * The benefit of this fix for somebody doing an upgrade from a previous LO
> installation is not evident:  As LO's msi installer keeps selected those
> features that were selected for the previous installation, this fix's
> pruning of the list of default-selected dictionaries would not kick in, and
> instead the default-selected list would cover exactly those dictionaries
> that were already installed before (which typically is all).  It only
> effectively affects brand-new installations.

I experienced strange behaviour with en-US-hu-ro 3 language build,
English dictionary was not selected. When I built all languages, it
worked as expected. So, I pushed these patches to libreoffice-3-6
branch, because they seem to work nicely in release build
configuration. Please note that it has l10n impact, because ID of
pt-BR dictionary name/description has been changes in scp2. I also
changed them in translations module and updated Pootle.

Best regards,
Andras