Re: How to use internal neon ?

On 10 September 2012 21:53, Caolán McNamara <caolanm@redhat.com> wrote:
> On Mon, 2012-09-10 at 18:55 +0200, Matúš Kukan wrote:
> > Hi,
> >
> > I am pondering gbuildizing neon.
> > It's built by dmake as dynamic library currently.
> > Could it be used as static library ?
>
> It used to be a static library but got converted to a shared library
> with 386b66d1a91f081b7f5f7673bfe640fa0d6b602c for
> https://issues.apache.org/ooo/show_bug.cgi?id=105418

I see, so it will be a little complicated with exporting symbols.
Currently, there is even .map file used. (probably, I don't know how
dmake works)
I've removed .map files, allowed to turn of -fvisibility=hidden in
https://gerrit.libreoffice.org/#/c/658/
and then tried to convert neon in
https://gerrit.libreoffice.org/#/c/659/
Seems to work for me on Linux.
Is this approach right ?

If anybody could try make ucb.all with MinGW and MacOSX, to see if it
links, that would be nice.
( with --enable-neon of course )

> > And why there is --disable-neon option if we can build internal copy ?
>
> This comes from https://issues.apache.org/ooo/show_bug.cgi?id=61380 as
> a5a236bc116ba38a6668f38bbb924ad333b7fdab

Good to know.

Thanks,
Matus