rtl includes in general

Stephan Bergmann <sbergman -AT- redhat.com>
Mon, 17 Sep 2012 18:48:12 +0200

On 09/17/2012 06:25 PM, Michael Stahl wrote:

i don't really think the performance benefit is that important; but
including it in a central place would give a consistency benefit in
whether assert is enabled, which sounds good to me...


...but why try and fight the Standard here?  I see no practical benefit.

We appear to have a handful of places in the code that fiddle withNDEBUG, for apparently dubious historical reasons. We should clean them up.

But why should anybody coming to this project not be able to expect theassert mechanism to be working as advertised by the Standard? (Afterthe above clean up, I assume there'll be no code left around that wouldfiddle with NDEBUG. But if there were, it would likely be for some reason.)


Stephan

Context

sal/config.g sal/types.h and sal/osl/rtl includes in general · Norbert Thiebaud
- Re: sal/config.g sal/types.h and sal/osl/rtl includes in general · Stephan Bergmann
  - Re: sal/config.g sal/types.h and sal/osl/rtl includes in general · Norbert Thiebaud
    - Re: sal/config.g sal/types.h and sal/osl/rtl includes in general · Lubos Lunak
    - Re: sal/config.g sal/types.h and sal/osl/rtl includes in general · Stephan Bergmann
      - Re: sal/config.g sal/types.h and sal/osl/rtl includes in general · Michael Stahl
        
        Re: sal/config.g sal/types.h and sal/osl/rtl includes in general · Stephan Bergmann
        
        Re: sal/config.g sal/types.h and sal/osl/rtl includes in general · Norbert Thiebaud
        
        Re: sal/config.g sal/types.h and sal/osl/rtl includes in general · Stephan Bergmann
        Re: sal/config.g sal/types.h and sal/osl/rtl includes in general · Michael Stahl
        
        Re: sal/config.g sal/types.h and sal/osl/rtl includes in general · d . ostrovsky
        Re: sal/config.g sal/types.h and sal/osl/rtl includes in general · Noel Grandin
        Re: sal/config.g sal/types.h and sal/osl/rtl includes in general · d . ostrovsky
        Re: sal/config.g sal/types.h and sal/osl/rtl includes in general · Michael Stahl
        new configure option --disable-cve-tests · David Ostrovsky
        
        Re: sal/config.g sal/types.h and sal/osl/rtl includes in general · Lubos Lunak
        
        Re: sal/config.g sal/types.h and sal/osl/rtl includes in general · Bjoern Michaelsen

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.