Re: [PROPOSED] Changes to General Options FDO#40656

 <http://opengrok.libreoffice.org/xref/core/cui/source/options/optjava.cxx#93>SvxJavaOptionsPage
<http://opengrok.libreoffice.org/s?refs=SvxJavaOptionsPage&project=core>::SvxJavaOptionsPage
<http://opengrok.libreoffice.org/s?refs=SvxJavaOptionsPage&project=core>(


On Fri, Sep 7, 2012 at 7:28 AM, Caolán McNamara <caolanm@redhat.com> wrote:

> On Thu, 2012-08-09 at 14:07 -0700, Joel Madero wrote:
> > Hi All,
> >
> > This is in response to
> > FDO#40656: https://bugs.freedesktop.org/show_bug.cgi?id=40656
> >
> >
> > In order to accomplish this I need to move some things around. I did
> > the visual changes - didn't do any of the functional changes yet, nor
> > did I ensure that spacing and what not is perfect. Looking for general
> > input before I put the time that is needed into this. Thanks all.
>
> Seems sane to me (seeing as I pushed the first patch in this process, I
> thought I'd better go back and have a look at the final picture). Though
> maybe (more work) "Measurements" would be better at the top, the rest of
> the general options are sort of obscure.
>
> C.
Shouldn't be a problem at all.



As for your other comment about changing name of help, how do I go about
doing this? I've never messed with the help stuff before so I'll need a bit
of guidance.

Also now that Java page has changed to Advanced, does it make sense to have
files named "optjava....cxx,src, etc..."? Should I consider changing the
names to something more sane since it's not just java? Also the page name
is now not really complete (svxJavaOptionsPage). If you give me some
guidance I'll move forward on that, until then I'll get at least the first
part of the measurements moved. I'm not sure if I'm going to redo the
measurements completely (ie. combine each components measurement into one)
or just have the option in general control all of them as is (ie.
separately). I'll figure that out as I go along.

Thanks for pushing that one out, it'll be nice when this change is done :)


Best Regards,
Joel