Re: [REVIEW 3-6] fdo#53006: Remove directories too, not just plain files

Petr Mladek <pmladek -AT- suse.cz>
Mon, 13 Aug 2012 11:38:05 +0200

Stephan Bergmann píše v Pá 10. 08. 2012 v 19:41 +0200:

On 08/10/2012 05:29 PM, Petr Mladek wrote:

Just to be sure. removeTree(url) removes only files and not directories.
Is it by intention? I think that both variants would be fine.


Oh, good catch.  No, it was an oversight to not remove directories.  So 
<http://cgit.freedesktop.org/libreoffice/core/commit/?id=0ab5ce54c441b12ea6c12a2cedb9069f36cfd0f4>
 
"fdo#53006: Remove directories too, not just plain files" fixes that.  I 
think it is best to backport it to libreoffice-3-6, too.  (Seen working 
as intended on both Linux and Windows master.)


Yup, looks and works fine => pushed into 3-6 branch.

Thanks for the fix.


Best Regards,
Petr

Context

[REVIEW 3-6] fdo#53006 Force reinstall of all bundled extensions on upgrade · Stephan Bergmann
- Re: [REVIEW 3-6] fdo#53006 Force reinstall of all bundled extensions on upgrade · Stephan Bergmann
- Re: [REVIEW 3-6] fdo#53006 Force reinstall of all bundled extensions on upgrade · Stephan Bergmann
  - Re: [REVIEW 3-6] fdo#53006 Force reinstall of all bundled extensions on upgrade · Stephan Bergmann
    - Re: [PUSHED 3-6] fdo#53006 Force reinstall of all bundled extensions on upgrade · Petr Mladek
      - [REVIEW 3-6] fdo#53006: Remove directories too, not just plain files · Stephan Bergmann
        
        Re: [REVIEW 3-6] fdo#53006: Remove directories too, not just plain files · Petr Mladek
        
        Re: [PUSHED 3-6] fdo#53006: Remove directories too, not just plain files · Petr Mladek
    - [REVIEW 3-6] fdo#53006: And detect LO downgrading scenarios · Stephan Bergmann
      - Re: [PUSHED 3-6] fdo#53006: And detect LO downgrading scenarios · Petr Mladek

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.