Re: [PUSHED 3-6] fdo#53006 Force reinstall of all bundled extensions on upgrade

Stephan Bergmann píše v Čt 09. 08. 2012 v 15:03 +0200:
> On 08/03/2012 06:10 PM, Stephan Bergmann wrote:
> > On 08/03/2012 11:24 AM, Stephan Bergmann wrote:
> > > <http://cgit.freedesktop.org/libreoffice/core/commit/?id=81fd6b084b0f3c0eb5a97c77592f5ceb21d2dfb1>
> > >
> > > "fdo#53006 Force reinstall of all bundled extensions on upgrade" are the
> > > two commits from master to get this fixed, which I would love to see
> > > backported to libreoffice-3-6.
> >
> > Please do *not* backport that one to libreoffice-3-6 for now.  I just
> > got an idea that might obsolete it...
>
> Finally got a new fix out, see 
> <https://bugs.freedesktop.org/show_bug.cgi?id=53006#c17> for details. 
> With the one old commit from this thread still relevant, that means 
> please review the three master commits
>
> ...and this time, I /did/ test on Windows 3.6, too. -- Lets keep fingers 
> crossed...

It looks quite robust. It means that the first start will be slower but
what we can do. => I have pushed it into 3-6 branch:
http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-6&id=40c80e6a637e80c220f3e39b855cd975c3e94799
http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-6&id=006e90e29c6ca768e3a5d8d2a558a63b04817c4b
http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-6&id=fd75125424b3dda0e77076d5b1709224ec22a345

Just to be sure. removeTree(url) removes only files and not directories.
Is it by intention? I think that both variants would be fine.

BTW: It worked well here with symlinks. I was not able to create
infinite loop with cyclic directories. So, we should be on the safe side
regarding the TODO comment.


> Petr, Björn, Rene:  With that fixed, prereg-affected Linux distros can 
> probably undo 
> <https://build.opensuse.org/package/view_file?file=force-refresh-of-bundled-extension-cache.diff&package=libreoffice&project=LibreOffice%3AUnstable>
>  
> "File force-refresh-of-bundled-extension-cache.diff of Package 
> libreoffice" or its moral equivalent (if any) again.

Yup, your changes do similar thing like the hack. I am going to double
check it with SUSE build because I was able to reproduce it here with
the SUSE package.

Thanks a lot for digging into it.


Best Regards,
Petr