Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index


Hi Tamas,

On Fri, Aug 10, 2012 at 10:57:12AM +0200, zolniatamas@caesar.elte.hu wrote:
+    ::rtl::OUString aString;

Just for the future: you can use simply OUString here, in internal code
the ::rtl:: prefix is no longer necessary. (I corrected this before
pushing.)

+    if ( aString.getLength() != 0 )

Anothor minor nit, there is isEmpty() for this purpose (forgot to
correct it before pushing, just keep in mind for your next patch).

Other than that, nice work, thanks! :)

Miklos

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.