Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index


Hi Tamas,

On Fri, Aug 10, 2012 at 10:19:19AM +0200, zolniatamas@caesar.elte.hu wrote:
+    String aString;

I know this is copied from existing code, but if you are at it, can't
you turn this into an OUString? most probably it'll work out of the box,
you just need to rename the class.

(See
http://wiki.documentfoundation.org/Development/String_Classes#Deprecated
)

-                SetText( aString );
+                SetText( String() );

Here as well.

-                if ( sItemCommand == ".uno:FindText" )
+                if ( sItemCommand == COMMAND_FINDTEXT )

Good catch. :)

Care to resubmit with this change, please?

Thanks,

Miklos

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.