Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index


Hey,

2012/7/20 Kohei Yoshida <kohei.yoshida@gmail.com>:
On 07/19/2012 12:31 PM, Eike Rathke wrote:

Hi,

Please review and cherry-pick to 3-6 and 3-6-0

http://cgit.freedesktop.org/libreoffice/core/commit/?id=b7dbc768a71ccfb567e3b2979e57d0d1318977cf
that fixes https://bugs.freedesktop.org/show_bug.cgi?id=52205


I reviewed and tested several csv files and one related pivot table use
case, and it did fix the bug.

The old behavior for ScSetStringParam::mbSetTextCellFormat was somewhat
confusing and there was a reason for that.  I now slightly changed the
behavior of that flag and you commit kept that new behavior.  But I couldn't
reproduce the original issue that the old behavior was intended to fix, so I
think it's safe to keep the new behavior.

Pushed to the -3-6 branch with my sign-off.   We need 2 more sign-offs to
push this to the -3-6-0 branch (I assume?).


Looks good to me. One more needed for 3-6-0.

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.