Re: [REVIEW 3-6, 3-6-0] [PUSHED 3-6] resolved fdo#52205 do not force all text cells in CSV import

Kohei Yoshida <kohei.yoshida -AT- gmail.com>
Fri, 20 Jul 2012 09:25:54 -0400

On 07/19/2012 12:31 PM, Eike Rathke wrote:

Hi,

Please review and cherry-pick to 3-6 and 3-6-0
http://cgit.freedesktop.org/libreoffice/core/commit/?id=b7dbc768a71ccfb567e3b2979e57d0d1318977cf
that fixes https://bugs.freedesktop.org/show_bug.cgi?id=52205

I reviewed and tested several csv files and one related pivot table usecase, and it did fix the bug.

The old behavior for ScSetStringParam::mbSetTextCellFormat was somewhatconfusing and there was a reason for that. I now slightly changed thebehavior of that flag and you commit kept that new behavior. But Icouldn't reproduce the original issue that the old behavior was intendedto fix, so I think it's safe to keep the new behavior.

Pushed to the -3-6 branch with my sign-off. We need 2 more sign-offsto push this to the -3-6-0 branch (I assume?).


Kohei

--
Kohei Yoshida, LibreOffice hacker, Calc

Context

[REVIEW 3-6, 3-6-0] resolved fdo#52205 do not force all text cells in CSV import · Eike Rathke
- Re: [REVIEW 3-6, 3-6-0] [PUSHED 3-6] resolved fdo#52205 do not force all text cells in CSV import · Kohei Yoshida
  - Re: [REVIEW 3-6, 3-6-0] [PUSHED 3-6] resolved fdo#52205 do not force all text cells in CSV import · Markus Mohrhard
  - [REVIEW 3-6-0] resolved fdo#52205 do not force all text cells in CSV import · Michael Meeks
    - [PUSHED 3-6-0] resolved fdo#52205 do not force all text cells in CSV import · Michael Meeks
  - ScSetStringParam::mbSetTextCellFormat (was: [REVIEW 3-6, 3-6-0] [PUSHED 3-6] resolved fdo#52205 do not force all text cells in CSV import) · Eike Rathke

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.