Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index


On Thu, 2012-07-19 at 23:05 +0200, Michael Stahl wrote:
since probably there's no good reason why loading resources may fail,
perhaps it would be a good idea to turn this one into an assert() that
aborts, so developers pay attention.

Yeah, thought about doing this myself. 

Where I often see them is from some of the IA2 accessibility stuff where
the ids ended up in the wrong places. e.g. added to dialog X .src and
used in dialog Y code.

Here's a sample fix for that. Moving them from the wrong place to the
right place.
http://cgit.freedesktop.org/libreoffice/core/commit/?id=8da9221b02429558bd61168b8f00b16ef714a34c

Less common is where the resource was removed (high contrast icons
typically) and the user of the resource is itself unused except for its
ctor/dtor. Here's a sample fix for that.
http://cgit.freedesktop.org/libreoffice/core/commit/?id=e133535eb8518b9dd22f4ce890a61f34f40d096b

C.


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.