Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index


Hey Eike, Kohei,

2012/7/19 Kohei Yoshida <kohei.yoshida@gmail.com>:
On 07/19/2012 10:29 AM, Eike Rathke wrote:

Hi,

Please review and cherry-pick to 3-6 and 3-6-0

http://cgit.freedesktop.org/libreoffice/core/commit/?id=a439cb5aba49d01df20f67a2c84b68542e4d3d5a
that resolves https://bugs.freedesktop.org/show_bug.cgi?id=50345
to accept empty string and strings containing only blanks as an argument
converted to numeric 0.


We already discussed this on IRC, but I disagree with this "fix" since it
basically breaks another valid use case that relies on the current behavior.
So, I'm afraid I cannot sign off on this.

Having said that, if someone else wants to sign off on this, then I'll stay
silent.


I'm also not fully convinced of this patch. This behavior has been in
Libreoffice since the start so IMHO it is more important to keep the
behavior for all the LibO users than to change it again to please
potential users switching from OOo.

I think the only sane solution that will please both sides is to have
it as configuration option but I'm not thrilled to see the default
behavior changed again.

This is just my opinion and if anyone still think it is a good idea
the patch looks correct from a technical perspective.

Regards,
Markus

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.