Re: [REVIEW 3-6, 3-6-0] fdo#50345 accept empty string as scalar numeric 0 argument

Kohei Yoshida <kohei.yoshida -AT- gmail.com>
Thu, 19 Jul 2012 10:37:25 -0400

On 07/19/2012 10:29 AM, Eike Rathke wrote:

Hi,

Please review and cherry-pick to 3-6 and 3-6-0
http://cgit.freedesktop.org/libreoffice/core/commit/?id=a439cb5aba49d01df20f67a2c84b68542e4d3d5a
that resolves https://bugs.freedesktop.org/show_bug.cgi?id=50345
to accept empty string and strings containing only blanks as an argument
converted to numeric 0.

We already discussed this on IRC, but I disagree with this "fix" sinceit basically breaks another valid use case that relies on the currentbehavior. So, I'm afraid I cannot sign off on this.

Having said that, if someone else wants to sign off on this, then I'llstay silent.


Kohei

--
Kohei Yoshida, LibreOffice hacker, Calc

Context

[REVIEW 3-6, 3-6-0] fdo#50345 accept empty string as scalar numeric 0 argument · Eike Rathke
- Re: [REVIEW 3-6, 3-6-0] fdo#50345 accept empty string as scalar numeric 0 argument · Kohei Yoshida
  - Re: [REVIEW 3-6, 3-6-0] fdo#50345 accept empty string as scalar numeric 0 argument · Markus Mohrhard
    - Re: [REVIEW 3-6, 3-6-0] fdo#50345 accept empty string as scalar numeric 0 argument · Andrew Douglas Pitonyak
    - Re: [REVIEW 3-6, 3-6-0] fdo#50345 accept empty string as scalar numeric 0 argument · Caolán McNamara
      - Re: [REVIEW 3-6, 3-6-0] fdo#50345 accept empty string as scalar numeric 0 argument · Kohei Yoshida
        
        Re: [REVIEW 3-6, 3-6-0] fdo#50345 accept empty string as scalar numeric 0 argument · Eike Rathke
        
        Re: [REVIEW 3-6, 3-6-0] fdo#50345 accept empty string as scalar numeric 0 argument · Kohei Yoshida
        
        Re: [REVIEW 3-6, 3-6-0] fdo#50345 accept empty string as scalar numeric 0 argument · Petr Mladek
        
        Re: [REVIEW 3-6, 3-6-0] fdo#50345 accept empty string as scalar numeric 0 argument · khagaroth
        
        Re: [REVIEW 3-6, 3-6-0] fdo#50345 accept empty string as scalar numeric 0 argument · Kohei Yoshida
        Re: [REVIEW 3-6, 3-6-0] fdo#50345 accept empty string as scalar numeric 0 argument · Eike Rathke

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.