Re: [REVIEW-3-6] fix for i#118877, don't remove ScPAtternAttr from doc pool when swapping rows/cols

Eike Rathke <erack -AT- redhat.com>
Fri, 13 Jul 2012 21:48:05 +0200

Hi Markus,

On Friday, 2012-07-13 20:39:07 +0200, Markus Mohrhard wrote:

In case of swapping we don't need all the special cases of ScAttrArray
for finding the right place and inserting removing from the doc pool,
we can just exchange the two pointers which is faster and does not
require manual manipulation of ref counts.


But, exchanging pointers works correctly only if both patterns cover
exactly one row each, not if one or both apply to more rows. So, while
inserting/removing from docpool may not be needed, splitting or merging
the area still is.

Or what do I miss? I didn't try the patch.

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD

Attachment: pgpcU2vcJuIA9.pgp
Description: PGP signature

Context

[REVIEW-3-6] fix for i#118877, don't remove ScPAtternAttr from doc pool when swapping rows/cols · Markus Mohrhard
- Re: [REVIEW-3-6] fix for i#118877, don't remove ScPAtternAttr from doc pool when swapping rows/cols · Eike Rathke
  - Re: [REVIEW-3-6] fix for i#118877, don't remove ScPAtternAttr from doc pool when swapping rows/cols · Markus Mohrhard
    - Re: [PUSHED-3-6] fix for i#118877, don't remove ScPAtternAttr from doc pool when swapping rows/cols · Eike Rathke

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.