[REVIEW-3-6] fix for i#118877, don't remove ScPAtternAttr from doc pool when swapping rows/cols

Markus Mohrhard <markus.mohrhard -AT- googlemail.com>
Fri, 13 Jul 2012 20:39:07 +0200

Hey,

[1] is a fix for i#118877. I did not like the idea from the apache bug
fix to manipulate the manual ref count and decided to implement a
cleaner solution for swapping rows/columns.

In case of swapping we don't need all the special cases of ScAttrArray
for finding the right place and inserting removing from the doc pool,
we can just exchange the two pointers which is faster and does not
require manual manipulation of ref counts.

Regards,
Markus

[1] http://cgit.freedesktop.org/libreoffice/core/commit/?id=902082656655aeab559c0b5781907ff004179468

Context

[REVIEW-3-6] fix for i#118877, don't remove ScPAtternAttr from doc pool when swapping rows/cols · Markus Mohrhard
- Re: [REVIEW-3-6] fix for i#118877, don't remove ScPAtternAttr from doc pool when swapping rows/cols · Eike Rathke
  - Re: [REVIEW-3-6] fix for i#118877, don't remove ScPAtternAttr from doc pool when swapping rows/cols · Markus Mohrhard
    - Re: [PUSHED-3-6] fix for i#118877, don't remove ScPAtternAttr from doc pool when swapping rows/cols · Eike Rathke

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.