Re: [Patch] Removed repeated calls in for loops in swnewtable.cxx

Jesso Murugan <developer.jesso -AT- gmail.com>
Mon, 9 Jul 2012 20:03:21 +0530

Hi Matteo,

   just a minor hint from my side: in the original code nBox was
   incremented only when "pBox == rBoxes[nBox]", while in the
   new one it happens unconditionally.


Sorry for over looking that.

 I don't know if this could be an issue or not.


I tested by re building and putting a breakpoint in this function,
stepping line by line. Everything was working fine, but, its
better to be cautious as I could have missed an edge case.

  To preserve the original behaviour a single conditional
  if ( nBox < nBoxCnt && pBox == rBoxes[nBox] )
  {
  could be used.


Should I send a new patch? or will the reviewers make the change
before pushing?

- Jesso Clarence

Context

[Patch] Removed repeated calls in for loops in swnewtable.cxx · Jesso Murugan
- Re: [Patch] Removed repeated calls in for loops in swnewtable.cxx · Matteo Casalin
  - Re: [Patch] Removed repeated calls in for loops in swnewtable.cxx · Jesso Murugan
    - Re: [Patch] Removed repeated calls in for loops in swnewtable.cxx · Matteo Casalin
      - Re: [Patch] Removed repeated calls in for loops in swnewtable.cxx · Jesso Murugan

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.