Re: [Patch] Removed repeated calls in for loops in swnewtable.cxx

Hi all,
    just a minor hint from my side: in the original code nBox was 
incremented only when "pBox == rBoxes[nBox]", while in the new one it 
happens unconditionally. I don't know if this could be an issue or 
not.
To preserve the original behaviour a single conditional

    if ( nBox < nBoxCnt && pBox == rBoxes[nBox] ) {

could be used.

Cheers
Matteo

--------------------------------------------------
Jesso Murugan <developer.jesso@gmail.com> wrote:
(09/07/2012 13:33)

> Hi,
>
> There were some repeated calls in two for loops in
> ExpandColumnSelection function in swnewtable.cxx
> so I combined the two loops so that the same calls
> need not be made again.
>
> I debugged and tested after making the changes,
> everything works as expected.
>
> - Jesso Clarence