From Björn Michaelsen <bjoern.michaelsen@canonical.com>:
Björn Michaelsen has uploaded a new change for review.
Change subject: Remove ugly statics in comphelper
......................................................................
Remove ugly statics in comphelper
in 'comphelper\source\misc\logging.cxx' we can read :
// (if ::rtl::OUString had an indexOfAscii, we could save those
ugly statics ...)
Well, it has kind of and indexOfAsciiL can be used if length is provided.
This patch is untested, so please check it before applying.
Especially, I've not checked for the includes for 'strlen'.
Change-Id: Ib241ea7d3766817e85977b4cd0ca27d5780c2616
---
M comphelper/source/misc/logging.cxx
1 file changed, 9 insertions(+), 17 deletions(-)
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/69/269/1
--
To view, visit https://gerrit.libreoffice.org/269
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib241ea7d3766817e85977b4cd0ca27d5780c2616
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Björn Michaelsen <bjoern.michaelsen@canonical.com>
Gerrit-Reviewer: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Context
- Change in core[master]: Remove ugly statics in comphelper · Gerrit
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.