Hi Matúš, On Wednesday, 2012-06-27 17:35:53 +0200, Matúš Kukan wrote:
.. the AccountContact struct seems ok to me. However, I'm missing the destruction of the created instances, this looks like a memory leak.I changed it to use boost::ptr_vector [1]. Are the instances going to be destroyed then ? I don't have experience with boost.
Yes, boost::ptr_vector takes ownership of pointers and deletes objects on destruction. The TpAccount* and TpConnect* in AccountContact may need some un/ref'ing as well, so g_object_ref( mpAccount) when storing and and g_object_unref( mpAccount) when releasing. Actually please try to avoid to pull-in telepathy and glib dependencies into application code, I'd prefer if we could encapsulate these things within the tubes module. IMHO we should not spread linkage to telepathy/glib further than absolutely necessary. Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD
Attachment:
pgpMU1fLy5ZrX.pgp
Description: PGP signature