Re: [PATCH] fdo#38828: Save position of tab dialogs

> Looks good. So...
>
> First up, can you add yourself to
> http://wiki.documentfoundation.org/Development/Developers and link to a
> mail that states that your submission is under our preferred MPL/LGPLv3+
> license combo. Most seem to go for a simple "all my patches unless I say
> otherwise"
>
> Second up, I wonder if we should do the "save position" thing *both* in
> the dtor and in the ::Ok handler that's called from apply. I mean, at
> the moment we seem to store which is the open tab and the position/size
> of the dialog on cancel/close too, do we want to continue doing that ?
>
> C.

I've sent a message to the mailing list. I'll add myself to the
developers list once the archives refresh.

Keeping it in the dtor and adding it to ::Ok sounds alright to me.
There aren't any convincing reasons I can come up for either way so
keeping the functionality the same is probably a safe bet. Really, it
seems like the in the long run it'd be better if these dialogs could
accept a functor or something so that they could update the document
on Apply without having to close the dialog first and then re-show it.
That way we wouldn't need to save any position info until the dtor was
called and the user wouldn't see the dialog flash when using Apply
(which also makes a bug I just noticed apparent where the dialog is
drawn down and to the right of its saved position at an offset that
seems equal to the size of its window decorations). Just some
thoughts. Should I roll a new patch with the code in the dtor?

-Travis