On Thu, 2012-06-21 at 20:03 -0500, Travis Carter wrote:
I've already submitted a patch that isn't as well formed to the bug
listing. Sorry. This was my first patch to any project and I should
have checked a little better on the preferred submission method. The
one attached here should be better.
Looks good. So...
First up, can you add yourself to
http://wiki.documentfoundation.org/Development/Developers and link to a
mail that states that your submission is under our preferred MPL/LGPLv3+
license combo. Most seem to go for a simple "all my patches unless I say
otherwise"
Second up, I wonder if we should do the "save position" thing *both* in
the dtor and in the ::Ok handler that's called from apply. I mean, at
the moment we seem to store which is the open tab and the position/size
of the dialog on cancel/close too, do we want to continue doing that ?
C.
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.