Re: [PUSHED 3-5][PUSHED 3-6][REVIEW 3-5-5?] fdo#47636 font fallback performance regression

Michael Meeks píše v Čt 21. 06. 2012 v 17:21 +0100:
> Hi there,
>
> On Thu, 2012-06-21 at 16:20 +0100, Caolán McNamara wrote:
> > So 8c023fd645c8b83637ffcde4055886b2e4f94393 should fix a performance
> > regression with font fallback under fontconfig using platforms when a
> > font is missing.
> >
> > This may be a duplicate of MAB fdo#44719. Fontconfig is fairly slow on
> > finding a replacement font so proposed solution is to cache the results.
>
>       You have my +1 for both branches (no need for review for -3-6 for this
> regression / bug IMHO) ;-) The patch is also a lot simpler when
> considering the revert of the original cache logic.
>
>       I'll push it in a bit if no-one else has - just building -3-5 currently
> to test the performance improvement.

It built fine, so I pushed it into 3-5 branch with Michael's approval,
see
http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5&id=eaf9cbd403f375f9b69e1c7ed8503d3bc23bcc6e

I saw it also in 3-6 branch.

The questions is if it is save enough for 3-5-5 branch. The problem is
that there won't be much testing before 3.5.5 release. Well, I do not
see anything wrong in the patch, so I might give one extra approval. So,
if we get one more...


Best Regards,
Petr