Re: [patch for 3.5.X] proposal of a patch to solve a crasher when saving a spreadsheet with track-change

Hey,

2012/6/21 Lionel Dricot <lionel@lanedo.com>:
> Hello,
>
> The crasher my colleague Pierre-Éric solved as been pushed to master,
> thanks Eike, thanks a lot for that :-)
> https://bugs.freedesktop.org/show_bug.cgi?id=51249
>
> Because this patch fixes a crasher, I would like to know if it would be
> possible to review it for the 3.5.X series.

Looks like a good workaround for the release branch but personally I'm
not happy with this patch for master. It very much looks like another
bug fix that just hides the problem instead of fixing the underlying
problem. I see no reason why we could not use the old stream if we
able change tracking and the stream is not marked invalid. Every bug
that prevents that very much looks like a problem that should be fixed
and not another ugly workaround added to hide it.

Anyway pushed to 3-5 with my sign-off. If you want it in 3-5-5 you
need to write a new mail with correct subject and 2 more sign-offs.
Please also use REVIEW-3-5 in the future.

Regards,
Markus