Re: bug 49610 in impress: suspicious commit found, but help needed

Hello,

I locally reverted
bdfbbb33a491f3ce34375de14ba33436b04

> - sadly the change mixes a lot of reformatting with that fix. Hard
> to tell if that is now causing some ripple effects. :/

I can confirm this is the origin of the problem. The generated bug is 
very nasty (creates data loss) and the fix has to / should be in 3.6 as 
well as in 3.5.5

I also have to say honestly that fixing this patch is beyond my 
knowledge of LibO code in this area. So if you say OK, I will push my 
revert to master. This is not the most polite way of fixing it. 
destroying your correction, but the one that fit to my knowledge there.

Or have you time to investigate it and fix it ? Sorry, this sounds not 
very constructive, but in this period I do not have a lot of free time, 
so I can not offer more.

Tack
regards
Pierre-André


On 06/20/2012 11:10 PM, Thorsten Behrens wrote:
> Pierre-André Jacquod wrote:
> > As I just do not understand what it is about here, (neither the goal
> > of the change nor the actual content), could you have a look about
> > it? I guess it will be the quickest way.
> Hi Pierre-André,
>
> well the goal was to decouple live cycles of Outliner and ViewShell
>
> Cheers,
>
> -- Thorsten
>
>
>
> _______________________________________________
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice