Re: PATCH: Add support for gnome-mail to send documents from file menu.

Hi,



On Wed, Jun 13, 2012 at 1:36 PM, Michael Meeks <michael.meeks@suse.com>wrote:

> Hi Peter,
>
> On Tue, 2012-06-12 at 16:04 +0200, Peter Tillemans wrote:
> > made available under the MPL/LGPLv3+
>
>         Lovely :-) what really helps is to have a blanket license
> statement for
> all your past/future commits sent to the list that we can link into:
>
>        http://wiki.documentfoundation.org/Development/Developers


 Something like this :
http://lists.freedesktop.org/archives/libreoffice/2012-June/033525.html



> > This patch adds support for gnome-gmail as mail user agent for sending
> > documents from the filemenu. This was super easy since the gnome-gmail
> > CLI is modelled on the one from evolution.
>
>         Neato :-) I look forward to merging that; while you're in that
> neck of
> the woods - any chance you could look at setting it up to use the
> 'xdg-email' app as well - I'd hope that that would be the final word in
> that script ;-)


 ➜  core git:(master) ✗ git diff
diff --git a/shell/source/unix/misc/senddoc.sh
b/shell/source/unix/misc/senddoc.sh
index a18562b..1ce60c8 100755
--- a/shell/source/unix/misc/senddoc.sh
+++ b/shell/source/unix/misc/senddoc.sh
@@ -208,7 +208,9 @@ case `basename "$MAILER" | sed 's/-.*$//'` in
         rm -f $BODY
         ;;

-    evolution)
+    evolution | gnome | xdg)
+        # gnome-mail is shortened from the dash on
+        # idem for xdg-email

         while [ "$1" != "" ]; do
             case $1 in


it'd be nice to default to that too. Defaults live in
> officecfg/ and/or come from some system detection logic somewhere - keys
> to git grep for might be ExternalMailer, CommandProfile etc.

I am trying to wrap my head around the default configuration. As it seems
on Linux xdg-email works on all common desktop environments, at least the
ones which also have a libreoffice autodetect driver. Then the autodetect
can be shortcircuited and xdg-email used as default.

However I am going to need some more study to change the default.

Peter Tillemans