Re: [PATCH][PUSHED] Remove non-functional Hide/ShowStatusText

On Mon, 2012-06-11 at 22:10 +0200, Thomas Arnhold wrote:
> I have some questions:
>
> - what's the matter about sfx2/inc/sfx2/sfxcommands.h? A quick check did 
> offer me that many of those defines are never used. Is it right to 
> remove the unused ones?

I've wondered myself. I don't know, but I'm inclined to think, like a
lot of stuff, that it's remnants of partially moving from one old scheme
to a new scheme and leaving unconverted bits behind. So best thing IMO
is to strip down to what's actually needed. and in the process figure
out from what's left behind what bits didn't get converted from old to
new.

> - hrc files: There were some comments that number XY was removed, should 
> I do this as well? I did this only at sw/source/ui/docvw/docvw.hrc 
> because the numbers before and after were set.

These .hrc files are super ugly hard coded numbers. Something gets
removed and rather than generate a huge diff a "hole" gets left which
can get reused, but noone ever reuses it cause its easier to add one at
the end rather than battle scary comments :-). AFAICS in general you
could happily change all the numbers around as long as they don't
conflict. That said, I at least once found old super-horrible code that
would "know" that adding +X to a id would find a matching one, e.g.
redostring_id = undostring_id + 3.

> - STR_DOC_LOADING and STR_CHAIN_OK were unused. They are represented in 
> many po files. Is there an easier way to remove them or only per regex/sed?

Stuff in .po files I think basically "take care of themselves", but
maybe Andras can give the right answer for that. I *presume* there's a
form of garbage collection taking place there so that translations of
removed stuff doesn't continue forever.

C.