Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index


On 06/06/12 17:41, Kevin Hunter wrote:
Hullo List,

Having been too excited last time (7+ months) and committed to master way too early, I'm back to basics as I try (once again) to get back into LO dev. Here's a minor cppcheck-found unused variable patch. Please review at your convenience.

Patch looks fine, thanks for that, pushed now. Btw if you are interested there are probably quite a few instances of VBA_OOBUILD_HACK buried in there that could do with removal ( and then finally wherever the -D for same passed to the compiler ) Cleaning those out would be appreciated ( by me at least ) Next time for convenience could you use 'git format-patch' for creating the diff ( just makes it easier to process ) thanks alot !!

Noel

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.