Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index


Hullo List,

Having been too excited last time (7+ months) and committed to master way too early, I'm back to basics as I try (once again) to get back into LO dev. Here's a minor cppcheck-found unused variable patch. Please review at your convenience.

Cheers,

Kevin
diff --git a/sc/source/ui/vba/vbarange.cxx b/sc/source/ui/vba/vbarange.cxx
index 99a2308..a1190bd 100644
--- a/sc/source/ui/vba/vbarange.cxx
+++ b/sc/source/ui/vba/vbarange.cxx
@@ -5530,15 +5530,10 @@ ScVbaRange::AutoFill(  const uno::Reference< excel::XRange >& Destination, 
const
             }
         }
     }
-    ScDocShell* pDocSh= excel::GetDocShellFromRange( mxRange );
 
     FillCmd eCmd = FILL_AUTO;
     FillDateCmd eDateCmd = FILL_DAY;
 
-#ifdef VBA_OOBUILD_HACK
-    double fEndValue =  MAXDOUBLE;
-#endif
-
     if ( Type.hasValue() )
     {
         sal_Int16 nFillType = excel::XlAutoFillType::xlFillDefault;
@@ -5581,6 +5576,8 @@ ScVbaRange::AutoFill(  const uno::Reference< excel::XRange >& Destination, 
const
         }
     }
 #ifdef VBA_OOBUILD_HACK
+    double fEndValue =  MAXDOUBLE;
+    ScDocShell* pDocSh = excel::GetDocShellFromRange( mxRange );
     pDocSh->GetDocFunc().FillAuto( aSourceRange, NULL, eDir, eCmd, eDateCmd,
                                    nCount, fStep, fEndValue, sal_True, sal_True );
 #endif

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.