Re: [PATCH] [WIP] fdo#45747 - [EasyHack] remove the limitation to 3 sort entries in calc, part 2

HI Marcus,
Sorry for not replying until now. Forgot to CC the list again...

On Tue, Jun 5, 2012 at 3:13 AM, Markus Mohrhard
<markus.mohrhard@googlemail.com> wrote:
> Hey Albert,
>
> > I already had a quick look at the closing problem and it seems it is
> > not a crash. It looks more like a missing close handler which results
> > in the parent window being closed which is in this case the LibO
> > window but I need to spend some more time on it. I will spend next
> > week on your patch and make sure that it is ready for 3-6.
>
> I finally had time to fix the issue with your patch and pushed it to master.
>
> The problem has been that vcl's window class destructor checks that
> all child windows are destroyed in dbgutil builds and your design did
> not ensure this. The changes that I did to your patch are in
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=57e35b0ed54a2e74c107493869e72ab7eb86222a.
>
> I also fixed a crash that I noticed when using more than 3 sort
> entries. I checked and the dialog looks good now.

Thanks for fixing this and getting it into 3.6! Also thanks for your
support during this work, I could not have done this without your
help. I'm very happy to see this being finished, although not so happy
about how long it took me to do this, but at least I learned a lot
along the way.

> Thanks a lot for this amazing work. I added it to the 3.6 release notes page.

I added a reference to the bug and a screenshot to the release notes.

> Regards,
> Markus

I have a few things lined up which I want to do next. For instance, do
you mind if I take a stab at this one:
https://bugs.freedesktop.org/show_bug.cgi?id=43937
I guess to fix this bug the best would be to implement the same
UI-magic here, as what I just did for the sort dialog.


/Albert