Re: [PATCH] [WIP] fdo#45747 - [EasyHack] remove the limitation to 3 sort entries in calc, part 2

Hey Albert,

2012/5/24 Albert Thuswaldner <albert.thuswaldner@gmail.com>:
> Hi Andras,
> Thanks for taking your time to reply.
>
> On Tue, May 22, 2012 at 5:50 PM, Andras Timar <timar74@gmail.com> wrote:
> > Hi Albert,
> >
> > 2012/5/18 Markus Mohrhard <markus.mohrhard@googlemail.com>:
> > > This one is quite simple. we need to move the identifiers out of the 0
> > > to 255 range.
> > >
> > > Andras, do you have an idea what range is useable in sc for this? I
> > > think most of the 256 to 999 range is already used but I have no idea
> > > where to check this.
> >
> > Sorry, I did not notice this mail. I hope it's not too late. Please
> > find attached a Perl script. You can move this script and scen-US.res
> > in a folder, run 'perl ./index.pl scen-US.res | sort -n' and you will
> > see the used global identifiers in sc module.
>
> I ran your script and it worked as expected. I've updated the global
> ids accordingly. Thanks for your help. :)
>
> > However, I find peculiar
> > that you put a Listbox and and Fixedline outside a dialog context, on
> > their own. If it works, why not, it just looks strange to me. :)
>
> Well I'm only copying an existing design based on Marcus advice. So it
> is not my crazy idea. ;)

I've looked at your patch and it looks really nice. Just one minor
question: Is there an add and a remove button?

I already had a quick look at the closing problem and it seems it is
not a crash. It looks more like a missing close handler which results
in the parent window being closed which is in this case the LibO
window but I need to spend some more time on it. I will spend next
week on your patch and make sure that it is ready for 3-6.

Regards,
Markus