Re: Advice needed about some cppcheck reports

On 29/05/12 16:04, Lubos Lunak wrote:
> On Tuesday 29 of May 2012, Michael Stahl wrote:
> > On 28/05/12 18:03, julien2412 wrote:
> > > Same thing here :
> > > [sal/osl/w32/file.cxx:880] -> [sal/osl/w32/file.cxx:880]: (style) Same
> > > expression on both sides of '-'.
> > >     876         if (nSize > 0)
> > >     877         {
> > >     878             c ^= pData[0];
> > >     879             pData += nSize;
> > >     880             nSize -= nSize;
> > >     881         }
> > >
> > > And here :
> > > [filter/source/graphicfilter/icgm/cgm.cxx:269] ->
> > > [filter/source/graphicfilter/icgm/cgm.cxx:269]: (style) Same expression
> > > on both sides of '-'.
> > >     267             if ( pLong[ nSwitch ] < 0 )
> > >     268             {
> > >     269                 nRetValue -= nRetValue;
> > >     270             }
> > >     271             nRetValue /= 65536;
> >
> > also makes sense
>
>  This is not the same, it looks more to me like it should be 'nRetValue 
> = -nRetValue;' to negate the value, especially given the abs() above.

d'oh, thanks for the correction, stupid me had overlooked that there
were 3 of these, i've only seen the first 2 but then added this comment
below the third one which i hadn't actually looked at :-/