Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index


On Tuesday 29 of May 2012, Michael Stahl wrote:
On 28/05/12 18:03, julien2412 wrote:
Same thing here :
[sal/osl/w32/file.cxx:880] -> [sal/osl/w32/file.cxx:880]: (style) Same
expression on both sides of '-'.
    876         if (nSize > 0)
    877         {
    878             c ^= pData[0];
    879             pData += nSize;
    880             nSize -= nSize;
    881         }

And here :
[filter/source/graphicfilter/icgm/cgm.cxx:269] ->
[filter/source/graphicfilter/icgm/cgm.cxx:269]: (style) Same expression
on both sides of '-'.
    267             if ( pLong[ nSwitch ] < 0 )
    268             {
    269                 nRetValue -= nRetValue;
    270             }
    271             nRetValue /= 65536;

also makes sense

 This is not the same, it looks more to me like it should be 'nRetValue 
= -nRetValue;' to negate the value, especially given the abs() above.

-- 
 Lubos Lunak
 l.lunak@suse.cz

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.