Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index


Hi David,

On Fri, 2012-05-25 at 13:28 +0200, David Tardon wrote:
There is experimental branch feature/tail_build that adds 19 more, but
it requires a change to build.pl, so I do not intend to push it into 3.6.
Of course, if people who actually know something about the build.pl
script look at commit 726ac115a981567b3f41613d0e0163bd010e6b17 and tell
me that I am not a total idiot, or even that it might work at the right
phase of moon, I can be convinced otherwise :-)

        I had the misfortune to hack on build.pl before :-) and your patch
looks reasonable to me. I'd love to have it in for 3.6 ... I didn't
checkout the branch and/or I couldn't make the make command that dumps
the deps work but I assume the parsing logic is fine. We may have some
explicit \r\n removal nonsense on windows (chomp has never worked well
for me there for some - prolly cygwin related reason) - but lets see.

-    my $modcount = %modules;
 
     return %modules;

        seems redundant in get_tail_build_modules.

         # insert dep. on tail_build, if necessary
         if (@tail_build_deps && !defined $$deps{$tail_build_prj}) {
             $$deps{$tail_build_prj} = 1;
         }

        The !defined looks redundant until you read get_parent_deps which has a
count of the deps in there.

        So - it all looks fine really :-) [ at least to me ]

        Thanks !

                Michael.

-- 
michael.meeks@suse.com  <><, Pseudo Engineer, itinerant idiot


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.