Re: [REVIEW][3-5] codemaker: write Java 1.5 class files

On 05/18/2012 05:53 PM, Michael Stahl wrote:
> for this reason i'm in favor of immediately dropping support for
> anything older than Java 1.5 on master, and also on libreoffice-3-5.
> (i don't actually know what our "official" Java baseline is, perhaps it
> is already 1.5?)

+1 on requiring a baseline of Java 1.5.  Not sure if anybody ever 
bothered to explicitly specify a Java baseline for LO, but Java 1.5 
would apparently be in line with old OOo, see 
<https://issues.apache.org/ooo/show_bug.cgi?id=92032> "Increase Java 
minimum version to 1.5 in jvmfwk."  (My memory told me that old OOo had 
still been at Java 1.4, but my memory was apparently wrong there.  The 
only potential gotcha would be that if you write extensions that shall 
be compatible with really old OOo, you would need to compile with really 
old javac -- but who cares.)

> the attached (uncommitted) patch changes codemaker to produce class
> files in version 49, supported by JREs 1.5 or later, effectively raising
> the baseline to Java 1.5 (if it is not there already).

So I'd say, apply that to both master and libreoffice-3-5 (i.e., you can 
use my sign-off for the latter).

Stephan