Re: [REVIEW-3-5] fdo#46355 sort SelectionTree control of Custom Setup with a custom action

Jesús Corrius <jesus -AT- softcatala.org>
Mon, 7 May 2012 11:08:43 +0200

Hi Andras,

If it fails, nothing special will happen. The control will not be
sorted, that is. I don't think we should stop and rollback the
install. We ignore the return code of most of our custom actions.


The behavior of FindWindow or FindWindowEx is different if some of the
parameters are NULL (If hwndParent is NULL, the function uses the
desktop window as the parent window). Although I agree that it is
highly unlikely that we do any collateral damage, a few IFs will
ensure that the code does what we want in all cases. So I would put
them even if we never show any error message.

-- 
Jesús Corrius <jesus@softcatala.org>

Context

[REVIEW-3-5] fdo#46355 sort SelectionTree control of Custom Setup with a custom action · Andras Timar
- Re: [REVIEW-3-5] fdo#46355 sort SelectionTree control of Custom Setup with a custom action · Jesús Corrius
  - Re: [REVIEW-3-5] fdo#46355 sort SelectionTree control of Custom Setup with a custom action · Andras Timar
    - Re: [REVIEW-3-5] fdo#46355 sort SelectionTree control of Custom Setup with a custom action · Jesús Corrius
      - Re: [REVIEW-3-5] fdo#46355 sort SelectionTree control of Custom Setup with a custom action · Andras Timar
        
        Re: [REVIEW-3-5] fdo#46355 sort SelectionTree control of Custom Setup with a custom action · Jesús Corrius
        
        Re: [PUSHED:3-5] fdo#46355 sort SelectionTree control of Custom Setup with a custom action · Petr Mladek

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.