Re: [REVIEW-3-5] fdo#46355 sort SelectionTree control of Custom Setup with a custom action

Andras Timar <timar74 -AT- gmail.com>
Mon, 7 May 2012 10:36:49 +0200

2012/5/7 Jesús Corrius <jesus@softcatala.org>:

Hi Andras,

On Sun, May 6, 2012 at 10:34 PM, Andras Timar <timar74@gmail.com> wrote:

 Fortunately the tree control under Windows can receive
a message that does the sort, so everything can be solved with pure
Windows API calls.

http://cgit.freedesktop.org/libreoffice/core/commit/?id=39bb77fd667f9d9fdaf374f3934b6eec7b7dc57a


The Windows code looks OK, but there's no error control anywhere and
that makes me shiver.


If it fails, nothing special will happen. The control will not be
sorted, that is. I don't think we should stop and rollback the
install. We ignore the return code of most of our custom actions.

Cheers,
Andras

Context

[REVIEW-3-5] fdo#46355 sort SelectionTree control of Custom Setup with a custom action · Andras Timar
- Re: [REVIEW-3-5] fdo#46355 sort SelectionTree control of Custom Setup with a custom action · Jesús Corrius
  - Re: [REVIEW-3-5] fdo#46355 sort SelectionTree control of Custom Setup with a custom action · Andras Timar
    - Re: [REVIEW-3-5] fdo#46355 sort SelectionTree control of Custom Setup with a custom action · Jesús Corrius
      - Re: [REVIEW-3-5] fdo#46355 sort SelectionTree control of Custom Setup with a custom action · Andras Timar
        
        Re: [REVIEW-3-5] fdo#46355 sort SelectionTree control of Custom Setup with a custom action · Jesús Corrius
        
        Re: [PUSHED:3-5] fdo#46355 sort SelectionTree control of Custom Setup with a custom action · Petr Mladek

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.