Re: [PATCH] fix proposed for fdo#49324

On 01/05/2012 14:06, Caolán McNamara wrote:
> On Tue, 2012-05-01 at 04:25 -0700, julien2412 wrote:
> > Hello,
> >
> > I reproduced the problem of fdo#49324 (Does not recognize VBA macro in
> > JAPANESE of LibreOffice 3.5.2) on master with Debian pc x86-64.
> > I noticed this line appeared twice in the log of the file which failed (see
> > https://bugs.freedesktop.org/show_bug.cgi?id=49324#c3)
> > warn:legacy.osl:17148:1:/home/julien/compile-libreoffice/libo/oox/source/helper/textinputstream.cxx:203:
> > TextInputStream::createXTextInputStream - unsupported text encoding
> > So I tested this patch :
> > http://nabble.documentfoundation.org/file/n3952784/patch_49324.txt
> > patch_49324.txt  and it worked.
> What happens if you replace the use of
> rtl_getMimeCharsetFromTextEncoding
> with
> rtl_getBestWindowsCharsetFromTextEncoding
> instead ?
>
> C.
Did you mean with or without the patch I proposed ?
I let the patch and just changed the line you quoted, I've got this when 
I recompile oox :
julien@julienPC:~/compile-libreoffice/libo$ make oox
cd oox && make -j 4 -rs gb_PARTIALBUILD=T
[ build CXX ] oox/source/helper/textinputstream.cxx
[ build CHK ] loaded modules: oox
/home/julien/compile-libreoffice/libo/oox/source/helper/textinputstream.cxx: 
In static member function ‘static 
com::sun::star::uno::Reference<com::sun::star::io::XTextInputStream> 
oox::TextInputStream::createXTextInputStream(const 
com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext>&, 
const com::sun::star::uno::Reference<com::sun::star::io::XInputStream>&, 
rtl_TextEncoding)’:
/home/julien/compile-libreoffice/libo/oox/source/helper/textinputstream.cxx:203:81: 
error: invalid conversion from ‘sal_uInt8 {aka unsigned char}’ to ‘const 
char*’ [-fpermissive]
make[1]: *** 
[/home/julien/compile-libreoffice/libo/workdir/unxlngx6/CxxObject/oox/source/helper/textinputstream.o] 
Erreur 1
make: *** [oox] Erreur 2

Julien.

PS : BTW, it seems there's a delay before the post is diplayed on dev 
mailing list (at least with Nabble). It's quite new since it was ok 
yesterday.