Re: [PATCH] fix proposed for fdo#49324

Caolán McNamara <caolanm -AT- redhat.com>
Tue, 01 May 2012 13:06:11 +0100

On Tue, 2012-05-01 at 04:25 -0700, julien2412 wrote:

Hello,

I reproduced the problem of fdo#49324 (Does not recognize VBA macro in
JAPANESE of LibreOffice 3.5.2) on master with Debian pc x86-64.
I noticed this line appeared twice in the log of the file which failed (see
https://bugs.freedesktop.org/show_bug.cgi?id=49324#c3) 
warn:legacy.osl:17148:1:/home/julien/compile-libreoffice/libo/oox/source/helper/textinputstream.cxx:203:
TextInputStream::createXTextInputStream - unsupported text encoding

So I tested this patch : 
http://nabble.documentfoundation.org/file/n3952784/patch_49324.txt
patch_49324.txt  and it worked.


What happens if you replace the use of
rtl_getMimeCharsetFromTextEncoding
with
rtl_getBestWindowsCharsetFromTextEncoding
instead ?

C.

Context

[PATCH] fix proposed for fdo#49324 · julien2412
- Re: [PATCH] fix proposed for fdo#49324 · Caolán McNamara
  - Re: [PATCH] fix proposed for fdo#49324 · Julien Nabet
    - Re: [PATCH] fix proposed for fdo#49324 · Caolán McNamara
      - Re: [PATCH] fix proposed for fdo#49324 · Julien Nabet
        
        Re: [PATCH] fix proposed for fdo#49324 · Caolán McNamara
        
        Re: [PATCH] [PUSHED on master] fix proposed for fdo#49324 · Julien Nabet
        
        Re: [PATCH] [PUSHED on master] fix proposed for fdo#49324 · Korrawit Pruegsanusak
        Re: [PATCH] [PUSHED on master] fix proposed for fdo#49324 · Julien Nabet
        Re: [PATCH] [PUSHED on master] fix proposed for fdo#49324 · Julien Nabet
        
        Re: [REVIEWED, PUSHED][REVIEW 3-5] fix proposed for fdo#49324 · Caolán McNamara
- Re: [PATCH] fix proposed for fdo#49324 · julien2412

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.